Closed
Conversation
nodejs-github-bot
added
console
alexsch01
changed the title
Member
|
Please change the base branch to v20.x-staging. Again, I don't think this even needs a backport PR, as the commit lands cleanly, and can be included in the next release |
Contributor
Author
|
@redyetidev does renaming my branch and doing another PR work? |
Member
|
IMHO I would hold off on the backport PR, and see if it is even needed. I'd wait until v20.X is prepared, and then see if it's even needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a833c9e.
PR-URL: #54677
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com