Conversation
Previously the order made no sense, especially since `toc.markdown` was alphabetized but `all.markdown` was not. This might fix issue nodejs#393 but after PR nodejs#553, I don't think we're on the same page.
|
The docs appear to alphabetize anyways; does this affect output at all? |
|
@Fishrock123 the list was already alphabetized, but the "all" page was not - this pull request changes the all page, nothing else. I should have clarified that. |
|
OH. LGTM, @chrisdickinson? |
|
👍 |
|
LGTM! |
|
Sorry @brendanashworth, I misunderstood your comment in #393. Am I right in understanding that there is no interest in reordering pages as in #553? |
|
@MattMS it wasn't your misunderstanding - I previously thought your intent was the same as illustrated in this PR, but then you opened #553 and I realized we probably didn't have the same intention, so I split what I had in mind into this PR and chose to let you continue with your idea. I'm not going to say that there is no interest - you do have solid reasoning behind it. I wouldn't drop it unless a strong reason to not do so is brought up. |
Previously `toc.markdown` was alphabetized but `all.markdown` was not. PR-URL: #566 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
|
Thanks @brendanashworth, sounds like a good plan 😄 This PR is a great start anyway! |
|
Fixed in 35a4f11 - thanks! |
5 participants
Previously the order made no sense, especially since
toc.markdownwasalphabetized but
all.markdownwas not.This might fix issue #393 but after PR #553, I don't think we're on the
same page.