Skip to content

os: fix netmask format check condition in getCIDR function #57324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Apr 20, 2025
Merged

os: fix netmask format check condition in getCIDR function #57324

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2e41b8
os: fix netmask format check condition in getCIDR function
HBSPS Mar 5, 2025
6e529a4
test: move getCIDR function to internal/util and add test code
HBSPS Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/os.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const {
Float64Array,
NumberParseInt,
ObjectDefineProperties,
StringPrototypeIncludes,
StringPrototypeSlice,
SymbolToPrimitive,
} = primordials;
Expand Down Expand Up @@ -244,7 +245,7 @@ function getCIDR(address, netmask, family) {
const binaryOnes = countBinaryOnes(binary);
ones += binaryOnes;
if (binaryOnes !== groupLength) {
if ((binary & 1) !== 0) {
if (StringPrototypeIncludes(binary.toString(2), '01')) {
return null;
}
hasZeros = true;
Expand Down
Loading