repl: fix multiline history editing string order#57874
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 16, 2025
Merged
repl: fix multiline history editing string order#57874nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
BridgeAR
reviewed
Apr 14, 2025
BridgeAR
reviewed
Apr 14, 2025
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
Would this also fix the flaky behavior reported in the comment? :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57874 +/- ##
==========================================
- Coverage 90.24% 90.24% -0.01%
==========================================
Files 630 630
Lines 185670 185694 +24
Branches 36401 36404 +3
==========================================
+ Hits 167567 167577 +10
- Misses 10992 10999 +7
- Partials 7111 7118 +7
🚀 New features to boost your workflow:
|
puskin
force-pushed
the
repl-edit-multiline-reverse-strig
branch
from
50800d0 to
39b827c
Compare
Contributor
Author
I just added some code which could fix the flakiness... I am not sure if it is good / clean enough tho, I didn't have any cooler idea 😞 |
BridgeAR
reviewed
Apr 14, 2025
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
I don't think the wait should make a difference for the test being flaky. I could imagine we run tests in parallel that use the same repl file to write to and they conflict with each other. Or is that unique to the current tmp directory?
The flaky result said we had two history entries.
Contributor
Author
|
Yeah I interpreted the two history entries as in a weird combination of keypresses which were not properly "awaited" for. Unfortunately I cannot reproduce the issue, let me investigate the "multiple access to the same history file" path EDIT: applied your suggestion, let's see if it happens again! |
puskin
force-pushed
the
repl-edit-multiline-reverse-strig
branch
from
39b827c to
4a9c482
Compare
BridgeAR
approved these changes
Apr 14, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
lpinca
reviewed
Apr 15, 2025
puskin
force-pushed
the
repl-edit-multiline-reverse-strig
branch
from
4a9c482 to
84f0885
Compare
puskin
force-pushed
the
repl-edit-multiline-reverse-strig
branch
from
84f0885 to
03cd310
Compare
lpinca
approved these changes
Apr 15, 2025
BridgeAR
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
pmarchini
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in af85f3f |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57874 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57874 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57874 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57874 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
PR-URL: #57874 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #57874 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57874 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57874 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57874 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
added
the
backport-requested-v22.x
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing an issue introduced in the last commit of #57400:
when editing a multiline history in REPL, the string gets reversed.
Added relevant automated tests