Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58021 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.01%
==========================================
Files 630 630
Lines 186158 186158
Branches 36484 36475 -9
==========================================
- Hits 168067 168051 -16
- Misses 10974 10988 +14
- Partials 7117 7119 +2 🚀 New features to boost your workflow:
|
aduh95
approved these changes
Apr 25, 2025
Collaborator
jasnell
approved these changes
Apr 26, 2025
H4ad
approved these changes
Apr 26, 2025
H4ad
reviewed
Apr 26, 2025
Comment on lines
+23
to
+24
| // Only javascript methods can be optimized through %OptimizeFunctionOnNextCall | ||
| // This is why we surround the C++ method we want to optimize with a JS function. |
Member
There was a problem hiding this comment.
I think is worthy to update the fast api docs to add this note, and maybe the exception when it's called with C++, just to be easy to find the docs when someone receive this error
Member
Author
|
Closing in favor of #58023 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes v8 fast api tests in test-whatwg-url-canparse.js