http: remove unused functions and add todos#58143
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 9, 2025
Merged
http: remove unused functions and add todos#58143nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58143 +/- ##
=======================================
Coverage 90.17% 90.18%
=======================================
Files 630 630
Lines 186473 186457 -16
Branches 36613 36609 -4
=======================================
- Hits 168160 168159 -1
+ Misses 11128 11117 -11
+ Partials 7185 7181 -4
🚀 New features to boost your workflow:
|
Collaborator
ShogunPanda
approved these changes
May 5, 2025
Contributor
ShogunPanda
left a comment
ShogunPanda
left a comment
There was a problem hiding this comment.
@anonrig LGTM as well.
Do you have a link on how eventually is supposed to be done?
Member
Author
I haven't created any issue. I'm planning on adding them soon. |
Collaborator
Collaborator
Collaborator
jasnell
approved these changes
May 7, 2025
Collaborator
Ethan-Arrowood
approved these changes
May 8, 2025
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in e46fb17 |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58143 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58143 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added TODOs to all functions that can be added a v8 fast api.