src: add a couple fast apis in node_os#58210
Closed
jasnell wants to merge 1 commit intonodejs:mainfrom
Closed
Conversation
nodejs-github-bot
added
c++
Collaborator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58210 +/- ##
==========================================
+ Coverage 90.18% 90.21% +0.02%
==========================================
Files 631 633 +2
Lines 186690 186852 +162
Branches 36666 36677 +11
==========================================
+ Hits 168360 168560 +200
+ Misses 11126 11093 -33
+ Partials 7204 7199 -5
🚀 New features to boost your workflow:
|
BridgeAR
reviewed
May 7, 2025
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
The code is LGTM, it would just be good to get some rests that verify the behavior as well.
addaleax
approved these changes
May 8, 2025
jasnell
force-pushed
the
jasnell/os-fast-apis
branch
2 times, most recently
from
e7847f4 to
5d581b4
Compare
Collaborator
jasnell
force-pushed
the
jasnell/os-fast-apis
branch
from
5d581b4 to
8ace295
Compare
anonrig
approved these changes
May 12, 2025
jasnell
added a commit
that referenced
this pull request
May 12, 2025
PR-URL: #58210 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Member
Author
|
Landed in 292263e |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58210 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58210 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couple of small fast api additions