Skip to content

deps: enable new JS features the V8 way #58230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 5 commits into from
Closed

deps: enable new JS features the V8 way #58230

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e3c1960
deps: patch V8 to 13.6.233.10
targos May 8, 2025
e09a299
deps: V8: cherry-pick 044b9b6f589d
rmahdav May 1, 2025
44f091a
deps: V8: cherry-pick 4f38995c8295
syg May 5, 2025
9c2d5d0
deps: V8: backport 1d3362c55396
syg May 6, 2025
fa6d943
src: remove unneeded explicit V8 flags
targos May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: backport 1d3362c55396 
Original commit message:

    [float16array] Turn flag on by default

    Float16Array has shipped in blink since M135. It is unlikely it'll
    unship by now, so turn the flag on by default.

    Bug: 42203953
    Change-Id: Ibd9de407b8810dd7bcdb46194fe04fc290ff8fb8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513988
    Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#100104}

Refs: v8/v8@1d3362c
Co-authored-by: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@syg @targos
syg and targos committed May 8, 2025
commit 9c2d5d06c46d8932e0d1ff598534637edc09f594
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.15',
'v8_embedder_string': '-node.16',

##### V8 defaults for Node.js #####

Expand Down
8 changes: 4 additions & 4 deletions deps/v8/src/flags/flag-definitions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,7 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")

// Features that are complete (but still behind the --harmony flag).
#define HARMONY_STAGED_BASE(V)
#define JAVASCRIPT_STAGED_FEATURES_BASE(V) \
V(js_float16array, \
"Float16Array, Math.f16round, DataView.getFloat16, DataView.setFloat16")
#define JAVASCRIPT_STAGED_FEATURES_BASE(V)

#ifdef V8_INTL_SUPPORT
#define HARMONY_STAGED(V) \
Expand All @@ -320,7 +318,9 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
V(js_atomics_pause, "Atomics.pause") \
V(js_error_iserror, "Error.isError") \
V(js_regexp_escape, "RegExp.escape") \
V(js_explicit_resource_management, "explicit resource management")
V(js_explicit_resource_management, "explicit resource management") \
V(js_float16array, \
"Float16Array, Math.f16round, DataView.getFloat16, DataView.setFloat16")

#ifdef V8_INTL_SUPPORT
#define HARMONY_SHIPPING(V) HARMONY_SHIPPING_BASE(V)
Expand Down
5 changes: 5 additions & 0 deletions deps/v8/src/init/bootstrapper.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5211,6 +5211,11 @@ DirectHandle<JSFunction> Genesis::InstallTypedArray(
GetCorrespondingRabGsabElementsKind(elements_kind), 0);
rab_gsab_initial_map->SetConstructor(*result);

if (rab_gsab_initial_map_index == Context::RAB_GSAB_FLOAT16_ARRAY_MAP_INDEX &&
v8_flags.js_float16array) {
LOG(isolate(), MapDetails(*rab_gsab_initial_map));
}

native_context()->set(rab_gsab_initial_map_index, *rab_gsab_initial_map,
UPDATE_WRITE_BARRIER, kReleaseStore);
Map::SetPrototype(isolate(), rab_gsab_initial_map, prototype);
Expand Down
4 changes: 0 additions & 4 deletions deps/v8/test/test262/test262.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2500,7 +2500,6 @@
'staging/sm/Temporal/PlainMonthDay/from-coptic': [FAIL],
'staging/sm/Temporal/PlainMonthDay/from-gregory': [FAIL],
'staging/sm/Temporal/PlainMonthDay/result-not-after-1972-dec-31': [FAIL],
'staging/sm/Math/f16round': [FAIL],
'staging/sm/RegExp/unicode-ignoreCase': [FAIL],
'staging/sm/String/string-code-point-upper-lower-mapping': [FAIL],
'staging/sm/String/string-upper-lower-mapping': [FAIL],
Expand All @@ -2511,13 +2510,10 @@
'staging/sm/TypedArray/prototype-constructor-identity': [FAIL],
'staging/sm/TypedArray/set-detached-bigint': [FAIL],
'staging/sm/TypedArray/seal-and-freeze': [FAIL],
'staging/sm/TypedArray/sort-negative-nan': [FAIL],
'staging/sm/TypedArray/sort_small': [FAIL],
'staging/sm/TypedArray/test-integrity-level': [FAIL],
'staging/sm/TypedArray/test-integrity-level-detached': [FAIL],
'staging/sm/TypedArray/toReversed-detached': [FAIL],
'staging/sm/TypedArray/toSorted-detached': [FAIL],
'staging/sm/TypedArray/toString': [FAIL],
'staging/sm/TypedArray/with': [FAIL],
'staging/sm/TypedArray/with-detached': [FAIL],
}],
Expand Down