Skip to content

fs: add disposable mkdtemp #58516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bakkot wants to merge 17 commits into from
+329 −0
Closed

fs: add disposable mkdtemp #58516

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5f9db1e
fs: add disposable mkdtempSync
bakkot May 30, 2025
55fffe7
switch to mkdtempDisposableSync
bakkot May 31, 2025
ca15b36
add async version
bakkot May 31, 2025
3a3e545
address non-test comments
bakkot Jun 10, 2025
c372931
remove initial version PR link from docs entirely
bakkot Jun 10, 2025
9295579
add tests
bakkot Jun 17, 2025
33dec17
fix Object capitalization in docs
bakkot Jun 17, 2025
b3b4771
fix lint errors
bakkot Jun 17, 2025
5a9282c
clean up docs slightly
bakkot Jun 17, 2025
c27abc2
fix link
bakkot Jun 17, 2025
82a21a3
add mkdtempDisposable to permissions tests
bakkot Jun 18, 2025
530dfc8
remove test for async pending fix for #58747
bakkot Jun 20, 2025
8dc0d54
update docs to add named interfaces
bakkot Jun 24, 2025
d216f6d
Revert "update docs to add named interfaces"
bakkot Jun 24, 2025
611d847
make SymbolDispose a wrapper not an alias
bakkot Jun 25, 2025
93b1e12
skip chdir tests on workers and rmdir tests on windows
bakkot Jun 28, 2025
ed2c3cf
inverted test, oops
bakkot Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix link
  • Loading branch information
@bakkot
bakkot committed Jun 17, 2025
commit c27abc24eb4ba6203d98bb56ce81e8ff8be0f936
2 changes: 1 addition & 1 deletion doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8555,7 +8555,7 @@ the file contents.
[`fs.writev()`]: #fswritevfd-buffers-position-callback
[`fsPromises.access()`]: #fspromisesaccesspath-mode
[`fsPromises.copyFile()`]: #fspromisescopyfilesrc-dest-mode
[`fsPromises.mkdtemp()`]: #fspromisesmkdtemp-prefix-options
[`fsPromises.mkdtemp()`]: #fspromisesmkdtempprefix-options
[`fsPromises.open()`]: #fspromisesopenpath-flags-mode
[`fsPromises.opendir()`]: #fspromisesopendirpath-options
[`fsPromises.rm()`]: #fspromisesrmpath-options
Expand Down
Loading