fix: avoid false DEP0155 warning for "./*" exports on Windows (#58650)#58684
Draft
vedant713 wants to merge 1 commit intonodejs:mainfrom
Draft
fix: avoid false DEP0155 warning for "./*" exports on Windows (#58650)#58684vedant713 wants to merge 1 commit intonodejs:mainfrom
vedant713 wants to merge 1 commit intonodejs:mainfrom
Conversation
…ows Ensure DEP0155 deprecation warning is only emitted for exact "./" export keys, not for "./*" or other subpath patterns. This avoids false positives when using valid pattern exports in package.json, aligning behavior with Node.js documentation.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
esm
Member
|
Thanks! Could you please include a test-case so we can avoid a regression? |
|
@vedant713 Did you find time to add tests yet? This would be useful for the wider community and has been sitting here for a while now |
Contributor
|
This is clearly not the right fix unfortunately. I will do some further investigation here. |
Contributor
|
I tried to replicate this today but was entirely unable to - #58650 (comment). If an updated replication is available please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"./"before displaying the warning."./*"and valid subpath exports are no longer affected.Fixes #58650