Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
convert DCHECK to CHECK
  • Loading branch information
anonrig committed Nov 25, 2025
commit 435f05d2709f3bf3f83d1f65db5e3a570b85f91c
16 changes: 9 additions & 7 deletions src/encoding_binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ size_t findBestFit(const Char* data, size_t length, size_t bufferSize) {
std::max(size_t{1}, std::max(guaranteedToFit, likelyToFit));
size_t chunkSize = std::min(remainingInput, fitEstimate);
if (chunkSize == 1) break;
DCHECK_GT(chunkSize, 1);
CHECK_GT(chunkSize, 1);

size_t chunkUtf8Len;
if constexpr (UTF16) {
Expand Down Expand Up @@ -198,14 +198,16 @@ void BindingData::EncodeInto(const FunctionCallbackInfo<Value>& args) {
char* write_result = static_cast<char*>(buf->Data()) + dest->ByteOffset();
size_t dest_length = dest->ByteLength();

// For small strings (length <= 32), use the old V8 path for better performance
// For small strings (length <= 32), use the old V8 path for better
// performance
if (source->Length() <= 32) {
size_t nchars;
size_t written = source->WriteUtf8V2(isolate,
write_result,
dest_length,
String::WriteFlags::kReplaceInvalidUtf8,
&nchars);
size_t written =
source->WriteUtf8V2(isolate,
write_result,
dest_length,
String::WriteFlags::kReplaceInvalidUtf8,
&nchars);
binding_data->encode_into_results_buffer_[0] = nchars;
binding_data->encode_into_results_buffer_[1] = written;
return;
Expand Down
Loading