Skip to content

[v25.x backport] util: fix nested proxy inspection #61152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LiviaMedeiros wants to merge 150 commits into
base: v25.x-staging
Choose a base branch
from
Open

[v25.x backport] util: fix nested proxy inspection #61152

LiviaMedeiros wants to merge 150 commits into from

Conversation

@LiviaMedeiros
Copy link
Member

@LiviaMedeiros LiviaMedeiros commented Dec 23, 2025

util: fix nested proxy inspection
Fixes: #61061
PR-URL: #61077
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: LiviaMedeiros livia@cirno.name
Reviewed-By: Juan José Arboleda soyjuanarbol@gmail.com
Reviewed-By: Gürgün Dayıoğlu hey@gurgun.day

Manual backport was required due to semver-major PRs that contain breaking changes and should be released in the next major version. change on main that adjusted formatting for proxies.

joyeecheung and others added 30 commits November 27, 2025 10:27
@joyeecheung @targos
esm: use wasm version of cjs-module-lexer
bf27b85 
The synchronous version has been available since 1.4.0.

PR-URL: nodejs#60663
Refs: nodejs#59913
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Renegade334 @targos
doc: domain.add() does not accept timer objects
712f944 
PR-URL: nodejs#60675
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@aduh95 @targos
tools: update x64 macOS runner
d915dfa 
PR-URL: nodejs#60676
Refs: actions/runner-images#13046
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@artsiom-malakhau @targos
doc: fix incorrect slh-dsa oids in crypto.md
40f9976 
Correct wrong object identifiers listed for slh-dsa algorithms in
doc/api/crypto.md. the valid range is from id-slh-dsa-sha2-128s
(2.16.840.1.101.3.4.3.20) through id-slh-dsa-shake-256f
(2.16.840.1.101.3.4.3.31), as defined in the ietf
draft-ietf-lamps-x509-slhdsa.

Fixes: nodejs#60680
Refs: https://datatracker.ietf.org/doc/draft-ietf-lamps-x509-slhdsa/
PR-URL: nodejs#60681
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@ChALkeR @targos
test: fix test-buffer-zero-fill-cli to be effective
4eeb0d1 
PR-URL: nodejs#60623
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@KevinEady @targos
node-api: support SharedArrayBuffer in napi_create_dataview
5ed8d03 
PR-URL: nodejs#60473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@panva @targos
lib: refactor JWK import PQC support check
eb44d07 
PR-URL: nodejs#60586
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ChALkeR @targos
buffer: let Buffer.of use heap
c890668 
PR-URL: nodejs#60503
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 @targos
doc: add info about renamed flag in cli.md
8a266d1 
PR-URL: nodejs#60690
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@Renegade334 @targos
meta: add Renegade334 to collaborators
29d0318 
Fixes: nodejs#60536
PR-URL: nodejs#60714
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot @targos
deps: update cjs-module-lexer to 2.1.1
4958d58 
PR-URL: nodejs#60646
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@islandryu @targos
http,https: fix double ERR_PROXY_TUNNEL emission
438aee0 
Fixes: nodejs#60697
PR-URL: nodejs#60699
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@nodejs-github-bot @targos
test: update WPT for WebCryptoAPI to c58b6f4e0e
a05bd35 
PR-URL: nodejs#60702
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@aduh95 @targos
test: ensure assertions are reached on more tests
eb4740d 
PR-URL: nodejs#60634
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot @targos
deps: update inspector_protocol to 1b1bcbbe060e8c8cd8704f00f78978c50991
15a74c0 
PR-URL: nodejs#60705
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@aduh95 @targos
doc: remove mention of SMS 2FA
5031a99 
PR-URL: nodejs#60707
Refs: nodejs/admin#1005
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@gurgunday @targos
lib: use FastBuffer for empty buffer allocation
557c9eb 
PR-URL: nodejs#60558
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@Renegade334 @targos
doc: correct tls ALPNProtocols types
3d7096e 
PR-URL: nodejs#60143
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@Renegade334 @targos
doc: correct and expand documentation for SQLTagStore
038f330 
PR-URL: nodejs#60200
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@seriousme @targos
lib: add support for readable byte streams to .toWeb()
2cb78c5 
Add support for the creation of ReadableByteStream to Readable.toWeb()
and Duplex.toWeb()
This enables the use of .getReader({ mode: "byob" }) on
e.g. socket().toWeb()

Refs: nodejs#56004 (comment)
Refs: https://developer.mozilla.org/en-US/docs/Web/API/Streams_API/Using_readable_byte_streams
PR-URL: nodejs#58664
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS @targos
src,permission: add debug log on is_tree_granted
0935da4 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: nodejs#60668
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@RafaelGSS @targos
src,permission: fix permission.has on empty param
795d73c 
PR-URL: nodejs#60674
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
@Han5991 @targos
test: add missing r.close() calls in REPL multiline tests
e093c6e 
Adds missing REPL instance cleanup calls to prevent resource leaks
in test/parallel/test-repl-multiline-navigation.js. Each test now
properly closes the REPL instance after testing cursor navigation.

PR-URL: nodejs#60226
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@joyeecheung @targos
doc,test: add documentation and test on how to use addons in SEA
e49f1c6 
PR-URL: nodejs#59582
Fixes: nodejs#60611
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@Madhu696969 @targos
doc: clarify license section and add contributor note
ee86297 
PR-URL: nodejs#60590
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
@targos
tools: update sccache to v0.12.0
6e0b0d3 
PR-URL: nodejs#60723
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@aduh95 @targos
test: ensure assertions are reached on more tests
dbb9418 
PR-URL: nodejs#60728
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@sravani1510 @targos
test: skip test that cause timeout on IBM i
0aed62f 
PR-URL: nodejs#60700
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@aduh95 @targos
test: ensure assertions are reached on HTTP tests
f3a889c 
PR-URL: nodejs#60729
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@aduh95 @targos
test: ensure assertions are reached on HTTP2 tests
d9bc0bf 
PR-URL: nodejs#60730
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
dependabot bot and others added 10 commits December 5, 2025 14:17
@dependabot @targos
tools: bump mdast-util-to-hast from 13.2.0 to 13.2.1 in /tools/doc
012bac1 
Bumps [mdast-util-to-hast](https://github.com/syntax-tree/mdast-util-to-hast) from 13.2.0 to 13.2.1.
- [Release notes](https://github.com/syntax-tree/mdast-util-to-hast/releases)
- [Commits](syntax-tree/mdast-util-to-hast@13.2.0...13.2.1)

---
updated-dependencies:
- dependency-name: mdast-util-to-hast
  dependency-version: 13.2.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#60930
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mertcanaltin @targos
src: implement Windows-1252 encoding support and update related tests
abdccc0 
PR-URL: nodejs#60893
Fixes: nodejs#60888
Fixes: nodejs#59515
Fixes: nodejs#56542
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@LiviaMedeiros @targos
http2,zlib: prefer call() over apply() if argument list is not array
2dcb1d8 
PR-URL: nodejs#60834
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS @targos
test: improve config-file permission test coverage
63eb50a 
Refs: nodejs#60746 (review)
PR-URL: nodejs#60929
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mag123c @aduh95
esm: improve error messages for ambiguous module syntax
685259c 
PR-URL: nodejs#60376
Fixes: nodejs#60322
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Mohit-Raj-Saxena @aduh95
doc: add File modes cross-references in fs methods
a8fe6c3 
Adds links to the File modes section from fsPromises.open(),
fsPromises.mkdir(), and fs.mkdir() to improve discoverability
of file permission documentation.

PR-URL: nodejs#60286
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@aduh95
tools: add some options and comments to shell.nix
747fd11 
PR-URL: nodejs#60911
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@aduh95
test: skip tests not passing without NODE_OPTIONS support
eb0705a 
PR-URL: nodejs#60912
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@RafaelGSS
deps: V8: cherry-pick 72b0e27bd936
9149ba4 
Original commit message:

    [regexp] Fix modifiers for ChoiceNodes

    Each alternative might modify flags when their sub-graph is emitted.
    We need to restore flags to the value at the beginning of a ChoiceNode
    for each alternative.

    Drive-by: Move regexp-modifiers test out of harmony/

    Fixed: 447583670
    Change-Id: I9f41e51f34df7659461da0a4fcd28b7e157f52e1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6995181
    Reviewed-by: Jakob Linke <jgruber@chromium.org>
    Commit-Queue: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#102838}

Refs: v8/v8@72b0e27
Refs: nodejs#60030
PR-URL: nodejs#60706
Backport-PR-URL: nodejs#60706
@Renegade334 @RafaelGSS
lib: do not provide an empty Proxy from localStorage getter
c57a40c 
PR-URL: nodejs#60776
Refs: nodejs#60303
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
@LiviaMedeiros LiviaMedeiros added util Issues and PRs related to the built-in util module. needs-ci PRs that need a full CI run. v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch. labels Dec 23, 2025
BridgeAR
BridgeAR approved these changes Dec 23, 2025
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a nit

@BridgeAR @LiviaMedeiros
util: fix nested proxy inspection
cc31e7d 
Fixes: nodejs#61061
PR-URL: nodejs#61077
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@targos targos mentioned this pull request Dec 23, 2025
Closed
@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 1, 2026
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 1, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - util: fix nested proxy inspection
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/20639704552

@avivkeller avivkeller added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jan 9, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 9, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70744/

@aduh95 aduh95 requested a review from a team as a code owner January 9, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@avivkeller avivkeller avivkeller approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.