Skip to content

src: add missing override specifier to Clean() #61429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jan 21, 2026
Merged

src: add missing override specifier to Clean() #61429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: add missing override specifier to Clean() 
The `CallbackInfo::Clean()` method overrides `Cleanable::Clean()` and
should be marked as `override`, both because it is good practice to do
so and for consistency with the rest of the code base.
  • Loading branch information
@tniessen
tniessen committed Jan 18, 2026
commit a86ff58dc3853e727e3eb112eb88fe099cfac02d
2 changes: 1 addition & 1 deletion src/node_buffer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class CallbackInfo : public Cleanable {
CallbackInfo& operator=(const CallbackInfo&) = delete;

private:
void Clean();
void Clean() override;
inline void OnBackingStoreFree();
inline void CallAndResetCallback();
inline CallbackInfo(Environment* env,
Expand Down
Loading