net: set ADDRCONFIG DNS hint in connections#6281
Merged
cjihrig merged 1 commit intonodejs:masterfrom Apr 20, 2016
Merged
Conversation
mscdex
added
dns
silverwind
added
dns
Member
|
LGTM. The issue on the pi2's is that they receive IPv6 addresses when they're IPv4-only or vice versa? |
Contributor
|
(Full) CI: https://ci.nodejs.org/job/node-test-pull-request/2324/ |
Member
|
LGTM |
Member
|
LGTM. Wouldn't mind seeing this get fast-tracked so that:
|
Member
|
CI is green. Multiple stress tests are green too. |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Contributor
Author
|
@bnoordhuis to be honest, I'm not sure. I'm not sure how those machines are configured. I was trying to fix the flakiness, and knew it could only be some combination of those two DNS hints. I'm glad it wasn't |
Contributor
Author
|
Oh, and @Trott thanks for running those stress tests. |
Member
|
LGTM |
Member
|
@cjihrig ... do you wanna land this? (or I can, I'm about to go through a batch of PR's again) |
b85a50b removed the implicit setting of DNS hints when creating a connection. This caused some of the pi2 machines to become flaky. This commit restores the implicit dns.ADDRCONFIG hint, but not dns.V4MAPPED. Fixes: nodejs#6133 PR-URL: nodejs#6281 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
This was referenced Apr 21, 2016
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
b85a50b removed the implicit setting of DNS hints when creating a connection. This caused some of the pi2 machines to become flaky. This commit restores the implicit dns.ADDRCONFIG hint, but not dns.V4MAPPED. Fixes: nodejs#6133 PR-URL: nodejs#6281 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
b85a50b removed the implicit setting of DNS hints when creating a connection. This caused some of the pi2 machines to become flaky. This commit restores the implicit dns.ADDRCONFIG hint, but not dns.V4MAPPED. Fixes: #6133 PR-URL: #6281 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
net
Description of change
b85a50b removed the implicit setting of DNS hints when creating a connection. Stress testing has shown that this caused the pi2 machines to become flaky. This commit restores the implicit
dns.ADDRCONFIGhint, but not the more problematicdns.V4MAPPED. The stress test in https://ci.nodejs.org/job/node-stress-single-test/655/ has, so far, stopped being flaky with this change.I'll update the commit message prior to landing.
Refs: #6133
Likely also
Refs: #6265
Refs: #6134