build: add shim to call node from wsl - #63101
Conversation
Signed-off-by: Nad Alaba <37968805+nadalaba@users.noreply.github.com>
|
The change looks OK to me. Before approving, I have one question: was this validated, and if so, how? |
|
@StefanStojanovic well node works from wsl without appending .exe now, so I'd say it's validated |
|
That's good, but there are a few more things that could be validated. For example, run The second thing that is worth validating is the MSI installer. Playing with it: install it, repair the installation after deleting the shim manually, upgrade to a new version, and uninstall. These should all work as expected (adding/removing the shim when expected). While I believe all of these things will work as expected, I'd still like you to try them to make sure all is as it should be. |
|
@StefanStojanovic Thanks for the suggestions. Yes, node resolution works as expected from all shells I tested: cmd, powershell, wsl, msys2, git bash. All msi operations (install/uninstall/repair/upgrade to a newer version) work as expected regarding the shim. If you're interested in getting windows‑node to behave correctly with WSL, #63118 might be relevant. Could you take a look at it? |
On Windows installation of node.exe, WSL shells cannot call
nodewithout the extension.exe.This PR adds a minimal shim to the installation directory that calls the main binary node.exe
Resolves conflicts from and closes #43948