test: deflake test-debugger-probe-timeout#63547
Merged
Merged
Conversation
On slow machines in the CI, the 200ms timeout may fire before the probed process finishes evaluation. Increase the timeout to common.platformTimeout(1000) to accomondate. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
nodejs-github-bot
added
needs-ci
trivikr
approved these changes
May 24, 2026
Collaborator
juanarbol
approved these changes
May 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63547 +/- ##
==========================================
- Coverage 91.77% 90.33% -1.44%
==========================================
Files 365 730 +365
Lines 158387 234161 +75774
Branches 24099 43916 +19817
==========================================
+ Hits 145357 211526 +66169
- Misses 12757 14378 +1621
- Partials 273 8257 +7984 🚀 New features to boost your workflow:
|
Member
|
The git merge conflict in |
jasnell
approved these changes
May 25, 2026
lpinca
approved these changes
May 25, 2026
Collaborator
joyeecheung
added
request-ci
Collaborator
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 221ffc0 |
aduh95
pushed a commit
that referenced
this pull request
May 27, 2026
On slow machines in the CI, the 200ms timeout may fire before the probed process finishes evaluation. Increase the timeout to common.platformTimeout(1000) to accomondate. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #63547 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-24.md Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On slow machines in the CI, the 200ms timeout may fire before the probed process finishes evaluation. Increase the timeout to common.platformTimeout(1000) to accomondate.
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-24.md