Skip to content

stream: use validateString for consumer encoding#64754

Open
sjungwon03 wants to merge 1 commit into
nodejs:mainfrom
sjungwon03:stream/use-validate-string-consumer-encoding
Open

stream: use validateString for consumer encoding#64754
sjungwon03 wants to merge 1 commit into
nodejs:mainfrom
sjungwon03:stream/use-validate-string-consumer-encoding

Conversation

@sjungwon03

Copy link
Copy Markdown
Contributor

Use validateString() for options.encoding in stream iterator consumers.

Add coverage for non-string values in the async and sync text consumers.

Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Jul 26, 2026
@sjungwon03
sjungwon03 marked this pull request as ready for review July 26, 2026 09:38
@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (4a5eb1c) to head (4913e0f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64754      +/-   ##
==========================================
- Coverage   90.15%   90.13%   -0.02%     
==========================================
  Files         744      744              
  Lines      242517   242514       -3     
  Branches    45688    45687       -1     
==========================================
- Hits       218642   218595      -47     
- Misses      15358    15420      +62     
+ Partials     8517     8499      -18     
Files with missing lines Coverage Δ
lib/internal/streams/iter/consumers.js 96.63% <100.00%> (-0.02%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mertcanaltin mertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants