sea: reject malformed --node-options values - #64803
Closed
Archkon wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Propagate tokenization errors from ParseNodeOptionsEnvVar through FixupArgsForSEA and abort startup with an invalid command-line status instead of applying partially parsed options. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64803 +/- ##
==========================================
- Coverage 90.16% 90.14% -0.03%
==========================================
Files 744 744
Lines 242518 242550 +32
Branches 45705 45699 -6
==========================================
- Hits 218670 218635 -35
- Misses 15357 15401 +44
- Partials 8491 8514 +23
π New features to boost your workflow:
|
jasnell
approved these changes
Aug 2, 2026
avivkeller
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
This comment was marked as spam.
This comment was marked as spam.
jasnell
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64803 β Done loading data for nodejs/node/pull/64803 ----------------------------------- PR info ------------------------------------ Title sea: reject malformed --node-options values (#64803) β Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Archkon:sea5 -> nodejs:main Labels c++, author ready, needs-ci, single-executable Commits 1 - sea: reject malformed --node-options values Committers 1 - Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/64803 Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64803 Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- βΉ This PR was created on Tue, 28 Jul 2026 11:14:57 GMT β Approvals: 1 β - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64803#pullrequestreview-4838561230 β 1 GitHub CI job(s) failed: β - x86_64-darwin: with shared libraries / build: FAILURE (https://github.com/nodejs/node/actions/runs/30359390795/job/90275679554) β 15 GitHub CI job(s) cancelled: β - test-tarball-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30359390085/job/90276855889) β - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30359390194/job/90275169419) β - lint-js-and-md: CANCELLED (https://github.com/nodejs/node/actions/runs/30359390226/job/90276327817) β - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30359390321/job/90275178023) β - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30359390455/job/90275132120) β - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30359390486/job/90275170435) β - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30359390486/job/90275170497) β - aarch64-darwin: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30359390795/job/90275679427) β - x86_64-linux: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30359390795/job/90275679472) β - aarch64-linux: with shared boringssl-0.20260526.0 / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30359390795/job/90275830670) β - aarch64-linux: with shared openssl-1.1.1w / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30359390795/job/90275830709) β - aarch64-linux: with shared openssl-3.5.7 / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30359390795/job/90275830715) β - aarch64-linux: with shared openssl-4.0.1 / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30359390795/job/90275830720) β - aarch64-linux: with shared openssl-3.6.3 / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30359390795/job/90275830776) β - aarch64-linux: with shared openssl-3.0.21 / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30359390795/job/90275830779) βΉ Last Full PR CI on 2026-08-05T02:23:34Z: https://ci.nodejs.org/job/node-test-pull-request/75495/ - Querying data for job/node-test-pull-request/75495/ β Build data downloaded β Last Jenkins CI successful -------------------------------------------------------------------------------- β Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/31265478955 |
avivkeller
pushed a commit
that referenced
this pull request
Aug 9, 2026
Propagate tokenization errors from ParseNodeOptionsEnvVar through FixupArgsForSEA and abort startup with an invalid command-line status instead of applying partially parsed options. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64803 Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in abbf086 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate tokenization errors from ParseNodeOptionsEnvVar through FixupArgsForSEA and abort startup with an invalid command-line status instead of applying partially parsed options.