sqlite: reject non-positive backup rates - #64893
Open
trivikr wants to merge 1 commit into
Open
Conversation
Passing a rate of 0 to backup() causes sqlite3_backup_step() to copy no pages. The backup job then continually reschedules itself and the returned promise never settles. Require backup rates to be positive integers to prevent zero-work backup jobs. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64893 +/- ##
==========================================
+ Coverage 90.14% 90.15% +0.01%
==========================================
Files 746 746
Lines 242849 242851 +2
Branches 45771 45768 -3
==========================================
+ Hits 218906 218939 +33
+ Misses 15438 15390 -48
- Partials 8505 8522 +17
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Aug 2, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64892
Passing a rate of
0tobackup()causessqlite3_backup_step()to copy no pages. The backup job then continually reschedules itself and the returned promise never settles.This change requires backup rates to be positive integers to prevent zero-work backup jobs.
Assisted-by: codex:gpt-5.6-sol