Skip to content

tools: fix pkcs11-store-test check - #65023

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fix-pkcs11-check
Aug 6, 2026
Merged

tools: fix pkcs11-store-test check#65023
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fix-pkcs11-check

Conversation

@aduh95

@aduh95 aduh95 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

openssl_3_5 was renamed to openssl in 3390622.

Refs: #64962 (comment)

`openssl_3_5` was renamed to `openssl` in 3390622.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 4, 2026
@panva

panva commented Aug 4, 2026

Copy link
Copy Markdown
Member

This is known to not work on future openssl versions yet which is why it's fixed to 3.5.x

@panva panva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fix the version back to 3.5 when the 4.1 upgrade comes around and new version of the pkcs11+softhsm stack isn't out by then.

@panva panva added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 4, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 6, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 9caf674 into nodejs:main Aug 6, 2026
45 of 46 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 9caf674

@aduh95
aduh95 deleted the fix-pkcs11-check branch August 6, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants