test: accept decoder errors for wrong FIPS passphrases - #65075
Closed
Archkon wants to merge 1 commit into
Closed
Conversation
Wrong-passphrase CBC decryption can occasionally produce valid padding. OpenSSL then parses the invalid plaintext and reports ASN.1 or decoder errors instead of bad decrypt. Accept these equivalent failures for FIPS-generated keys while keeping strict checks for fixed non-FIPS fixtures. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
nodejs-github-bot
added
needs-ci
This comment was marked as spam.
This comment was marked as spam.
panva
approved these changes
Aug 6, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65075 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.01%
==========================================
Files 759 759
Lines 247646 247754 +108
Branches 46697 46725 +28
==========================================
+ Hits 223654 223740 +86
- Misses 15463 15481 +18
- Partials 8529 8533 +4 🚀 New features to boost your workflow:
|
This comment was marked as spam.
This comment was marked as spam.
Collaborator
avivkeller
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/65075 ✔ Done loading data for nodejs/node/pull/65075 ----------------------------------- PR info ------------------------------------ Title test: accept decoder errors for wrong FIPS passphrases (#65075) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Archkon:testerror -> nodejs:main Labels test, author ready, needs-ci, commit-queue Commits 1 - test: accept decoder errors for wrong FIPS passphrases Committers 1 - Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/65075 Reviewed-By: Filip Skokan <panva.ip@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65075 Reviewed-By: Filip Skokan <panva.ip@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 06 Aug 2026 09:40:16 GMT ✔ Approvals: 1 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65075#pullrequestreview-4874270829 ✘ This PR needs to wait 87 more hours to land (or 0 minutes if there is one more approval) ✘ GitHub CI is still running ℹ Last Full PR CI on 2026-08-06T14:01:02Z: https://ci.nodejs.org/job/node-test-pull-request/75569/ - Querying data for job/node-test-pull-request/75569/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/31330750033 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrong-passphrase CBC decryption can occasionally produce valid padding. OpenSSL then parses the invalid plaintext and reports ASN.1 or decoder errors instead of bad decrypt.
To fix the flaky test that encountered at https://github.com/nodejs/node/actions/runs/31081775174/job/92552480382