Skip to content

process: validate debugPort strictly before narrowing - #65134

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:process8
Open

process: validate debugPort strictly before narrowing#65134
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:process8

Conversation

@Archkon

@Archkon Archkon commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Validate process.debugPort before extracting and narrowing its value. This prevents invalid inputs from changing the configured port and stops large integers from wrapping during 32-bit conversion.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 8, 2026
Validate process.debugPort before extracting and narrowing its value.
This prevents invalid inputs from changing the configured port and stops
large integers from wrapping during 32-bit conversion.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@codecov

codecov Bot commented Aug 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (73236f3) to head (3023150).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65134      +/-   ##
==========================================
- Coverage   90.31%   90.31%   -0.01%     
==========================================
  Files         759      759              
  Lines      248295   248298       +3     
  Branches    46863    46862       -1     
==========================================
+ Hits       224242   224244       +2     
- Misses      15460    15470      +10     
+ Partials     8593     8584       -9     
Files with missing lines Coverage Δ
src/node_process_object.cc 86.06% <100.00%> (+0.35%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants