Skip to content

http: optimize checkIsHttpToken() and checkInvalidHeaderChar() #6570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscdex merged 5 commits into from
Jun 14, 2016
+217 −50
Merged

http: optimize checkIsHttpToken() and checkInvalidHeaderChar() #6570

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
918159e
http: optimize checkIsHttpToken()
mscdex May 4, 2016
83432bf
http: optimize checkInvalidHeaderChar()
mscdex May 7, 2016
39fdf07
benchmark: increase http token check iterations
mscdex May 7, 2016
c8fa79f
test: add more http token/value checking tests
mscdex May 7, 2016
c570182
benchmark: don't convert arguments to numbers
mscdex May 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
benchmark: don't convert arguments to numbers 
PR-URL: #6570
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
@mscdex
mscdex committed Jun 14, 2016
commit c570182a39ada502d0f65223728b0cd9e136cda0
4 changes: 1 addition & 3 deletions benchmark/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,7 @@ function parseOpts(options) {
if (!match || !match[1] || !options[match[1]]) {
return null;
} else {
conf[match[1]] = (match[2].length && isFinite(match[2])
? +match[2]
: match[2]);
conf[match[1]] = match[2];
num--;
}
}
Expand Down