Closed
Conversation
Member
|
Is this going to be excluded on centos (which I also saw failing in the ci) as well ? Just want to understand if excluding or trying to fix is the right thing to do ? |
Contributor
Author
|
@mhdawson can you point me to a failure? |
Contributor
Author
|
Looks like Centos did also fail here: |
Contributor
Author
|
Looks like @santigimeno has an idea in #6716 (comment) |
Member
|
Hopeful fix from @santigimeno's idea/comment: #6722 EDIT: Whoops, fixed the link. |
Contributor
Author
|
@Trott that links to nothing? |
Contributor
Author
|
Closing in favor of #6728 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Refs: #2253 (comment)
Fixes: #6716
cc @bmeck & @mhdawson
Maybe we should be changing this to only skip the stdin part of the test? It seems like that is the bit causing issues?
CI: https://ci.nodejs.org/job/node-test-pull-request/2609/