-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
test: ensure stream preprocessing order #7741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
df751d9
50fd2c8
06f89b8
d74e6df
62379f3
099a111
a05ea83
473da05
376ea47
f41dca2
6d7e25f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /******************************************************************************/ | ||
| 'use strict'; | ||
| /******************************************************************************/ | ||
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
|
|
||
| const fs = require('fs'); | ||
| const path = require('path'); | ||
| const rl = require('readline'); | ||
| /******************************************************************************/ | ||
| const BOM = '\uFEFF'; | ||
|
|
||
| // get the data by a non-stream way to compare with the streamed data | ||
|
||
| const modelData = fs.readFileSync( | ||
| path.join(__dirname, '..', 'fixtures', 'file-to-read-without-bom.txt'), 'utf8' | ||
|
||
| ); | ||
| const modelDataFirstCharacter = modelData[0]; | ||
|
|
||
| // detect the number of forthcoming 'line' events for mustCall() 'expected' arg | ||
| const linesNumber = modelData.match(/\n/g).length; | ||
|
||
| /******************************************************************************/ | ||
| // ensure both without-bom and with-bom test files are textwise equal | ||
| assert.strictEqual( | ||
| fs.readFileSync( | ||
| path.join(__dirname, '..', 'fixtures', 'file-to-read-with-bom.txt'), 'utf8' | ||
| ), | ||
| `${BOM}${modelData}` | ||
| ); | ||
| /******************************************************************************/ | ||
| // an unjustified BOM stripping with a non-BOM character unshifted to a stream | ||
| const inputWithoutBOM = fs.createReadStream( | ||
| path.join(__dirname, '..', 'fixtures', 'file-to-read-without-bom.txt'), 'utf8' | ||
| ); | ||
|
|
||
| inputWithoutBOM.once('readable', common.mustCall(() => { | ||
| const maybeBOM = inputWithoutBOM.read(1); | ||
| assert.strictEqual(maybeBOM, modelDataFirstCharacter); | ||
|
|
||
| if (maybeBOM !== BOM) inputWithoutBOM.unshift(maybeBOM); | ||
|
||
|
|
||
| let streamedData = ''; | ||
| rl.createInterface({ | ||
| input: inputWithoutBOM, | ||
| }).on('line', common.mustCall((line) => { | ||
| streamedData += `${line}\n`; | ||
| }, linesNumber)).on('close', common.mustCall(() => { | ||
| assert.strictEqual(streamedData, modelData); | ||
| })); | ||
| })); | ||
| /******************************************************************************/ | ||
| // a justified BOM stripping | ||
| const inputWithBOM = fs.createReadStream( | ||
| path.join(__dirname, '..', 'fixtures', 'file-to-read-with-bom.txt'), 'utf8' | ||
| ); | ||
|
|
||
| inputWithBOM.once('readable', common.mustCall(() => { | ||
| const maybeBOM = inputWithBOM.read(1); | ||
| assert.strictEqual(maybeBOM, BOM); | ||
|
|
||
| if (maybeBOM !== BOM) inputWithBOM.unshift(maybeBOM); | ||
|
|
||
| let streamedData = ''; | ||
| rl.createInterface({ | ||
| input: inputWithBOM, | ||
| }).on('line', common.mustCall((line) => { | ||
| streamedData += `${line}\n`; | ||
| }, linesNumber)).on('close', common.mustCall(() => { | ||
| assert.strictEqual(streamedData, modelData); | ||
| })); | ||
| })); | ||
| /******************************************************************************/ | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a minor nit, but in keeping with the style of most of the other tests, it's probably best to just replace this line with a blank line and remove the other two earlier asterisk lines completely.