Skip to content

build: fix dependency on missing header file #7945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 2 commits into from
Aug 3, 2016
Merged

build: fix dependency on missing header file #7945

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0676f3
build: fix typo in non-essential source file name
bnoordhuis Aug 2, 2016
05c15a0
build: fix dependency on missing header file
bnoordhuis Aug 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build: fix dependency on missing header file 
Depend on include/ares_rules.h, src/ares_rules.h does not exist.

The typo didn't break the build but it made some of the gyp-based
tooling complain.

PR-URL: #7945
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
  • Loading branch information
@bnoordhuis
bnoordhuis committed Aug 3, 2016
commit 05c15a057f230f2ab338b7b81e59a2ce32dd8bd8
2 changes: 1 addition & 1 deletion deps/cares/cares.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
'sources': [
'common.gypi',
'include/ares.h',
'include/ares_rules.h',
'include/ares_version.h',
'include/nameser.h',
'src/ares_cancel.c',
Expand Down Expand Up @@ -83,7 +84,6 @@
'src/ares_process.c',
'src/ares_query.c',
'src/ares__read_line.c',
'src/ares_rules.h',
'src/ares_search.c',
'src/ares_send.c',
'src/ares_setup.h',
Expand Down