Skip to content

url: significantly improve the performance of the url module #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petkaantonov wants to merge 34 commits into from
Closed

url: significantly improve the performance of the url module #933

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
e61ee49
Working on v2.0.0
chrisdickinson Apr 17, 2015
6870764
doc: update CONTRIBUTING.md
brendanashworth Apr 18, 2015
7180597
Revert "http: don't bother making a copy of the options"
brendanashworth Apr 18, 2015
6bf85bc
test: add test for 06cfff9 regression
brendanashworth Apr 18, 2015
59a5c98
Merge v1.8.1.
chrisdickinson Apr 21, 2015
2632775
doc: update AUTHORS list
rvagg Apr 20, 2015
b16a328
doc: add spaces to child.kill example
enaqx Apr 22, 2015
22aafa5
doc: add Fishrock123 to the TC
Fishrock123 Apr 23, 2015
a7d7463
tls_wrap: use localhost if options.host is empty
sitegui Apr 21, 2015
7384ca8
module: remove '' from Module.globalPaths
chrisyip Apr 21, 2015
bb254b5
doc: update branch to master
silverwind Apr 23, 2015
3d3083b
buffer: little improve for Buffer.concat method
JacksonTian Apr 16, 2015
1bef717
net: cleanup connect logic
evanlucas Apr 22, 2015
4abe2fa
net: add lookup option to Socket.prototype.connect
evanlucas Apr 22, 2015
f3cc50f
doc: add TC meeting 2015-04-08 minutes
rvagg Apr 22, 2015
5178f93
doc: Add Addon API (NAN) to working group list
julianduque Apr 25, 2015
bf7ac08
util: add Map and Set inspection support
monsanto Apr 20, 2015
3bda6cb
win,node-gyp: enable delay-load hook by default
piscisaureus Apr 15, 2015
5472139
test: adjust Makefile/test-ci, add to vcbuild.bat
rvagg Apr 26, 2015
bfae823
test: fix test-net-dns-custom-lookup test assertion
evanlucas Apr 26, 2015
2a3c8c1
build: remove -J from test-ci
rvagg Apr 28, 2015
e55fdc4
doc: fix util.deprecate example
enaqx Apr 27, 2015
0fa6c4a
string_decoder: don't cache Buffer.isEncoding
mscdex Apr 28, 2015
391cae3
doc: Add Known issues to v1.7.0/1.7.1 CHANGELOG
yosuke-furukawa Apr 20, 2015
1bcdf46
doc: add TC meeting 2015-04-15 minutes
rvagg Apr 22, 2015
b57cc51
os: remove trailing slash from os.tmpdir()
tellnes Feb 6, 2015
36cd5fb
deps: upgrade v8 to 4.2.77.13
bnoordhuis Mar 27, 2015
db4ded5
deps: enable v8 postmortem debugging again
bnoordhuis Mar 27, 2015
01e6632
deps: upgrade v8 to 4.2.77.15
bnoordhuis Apr 11, 2015
01652c7
deps: upgrade v8 to 4.2.77.18
chrisdickinson Apr 25, 2015
509b59e
deps: enable v8 postmortem debugging again
bnoordhuis Mar 27, 2015
f9c681c
fs: validate fd on fs.write
julianduque Apr 28, 2015
f9b226c
test: extend timeouts for ARMv6
rvagg Apr 29, 2015
bf07d13
url: significantly improve the performance of the url module
petkaantonov Mar 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: enable v8 postmortem debugging again 
Cherry-pick https://codereview.chromium.org/1033733003 from upstream
and re-enable postmortem debugging.

PR-URL: #1232
Reviewed-By: Fedor Indutny <fedor@indutny.com>
  • Loading branch information
@bnoordhuis @chrisdickinson
bnoordhuis authored and chrisdickinson committed Apr 28, 2015
commit db4ded5903c8206ea5cdb7fe036247f9df70b052
5 changes: 2 additions & 3 deletions common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,16 @@
# Enable disassembler for `--print-code` v8 options
'v8_enable_disassembler': 1,

# Disable support for postmortem debugging, continuously broken.
'v8_postmortem_support%': 'false',

# Don't bake anything extra into the snapshot.
'v8_use_external_startup_data%': 0,

'conditions': [
['OS == "win"', {
'os_posix': 0,
'v8_postmortem_support%': 'false',
}, {
'os_posix': 1,
'v8_postmortem_support%': 'true',
}],
['GENERATOR == "ninja" or OS== "mac"', {
'OBJ_DIR': '<(PRODUCT_DIR)/obj',
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/tools/gen-postmortem-metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
{ 'name': 'prop_idx_first',
'value': 'DescriptorArray::kFirstIndex' },
{ 'name': 'prop_type_field',
'value': 'FIELD' },
'value': 'DATA' },
{ 'name': 'prop_type_mask',
'value': 'PropertyDetails::TypeField::kMask' },
{ 'name': 'prop_index_mask',
Expand Down