Skip to content

test: Using const instead of var. #9926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ftatieze wants to merge 2 commits into from
Closed

test: Using const instead of var. #9926

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9102210
test: Using const instead of var.
ftatieze Dec 1, 2016
1f48698
using strictEqual instead of equal.
ftatieze Dec 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
using strictEqual instead of equal.
  • Loading branch information
@ftatieze
ftatieze committed Dec 1, 2016
commit 1f48698915eadd26105cfc1ca739da5c3937fe5b
10 changes: 5 additions & 5 deletions test/parallel/test-console-instance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ process.stdout.write = process.stderr.write = function() {
};

// make sure that the "Console" function exists
assert.equal('function', typeof Console);
assert.strictEqual('function', typeof Console);

// make sure that the Console constructor throws
// when not given a writable stream instance
Expand All @@ -35,7 +35,7 @@ out.write = err.write = function(d) {};
var c = new Console(out, err);

out.write = err.write = function(d) {
assert.equal(d, 'test\n');
assert.strictEqual(d, 'test\n');
called = true;
};

Expand All @@ -48,7 +48,7 @@ c.error('test');
assert(called);

out.write = function(d) {
assert.equal('{ foo: 1 }\n', d);
assert.strictEqual('{ foo: 1 }\n', d);
called = true;
};

Expand All @@ -60,10 +60,10 @@ assert(called);
called = 0;
out.write = function(d) {
called++;
assert.equal(d, called + ' ' + (called - 1) + ' [ 1, 2, 3 ]\n');
assert.strictEqual(d, called + ' ' + (called - 1) + ' [ 1, 2, 3 ]\n');
};
[1, 2, 3].forEach(c.log);
assert.equal(3, called);
assert.strictEqual(3, called);

// Console() detects if it is called without `new` keyword
assert.doesNotThrow(function() {
Expand Down