Skip to content

Test console fix assert equals #9942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcrummey wants to merge 4 commits into from
Closed

Test console fix assert equals #9942

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26e6ace
renamed
Dec 1, 2016
7dc4f58
fixing linter errors
Dec 1, 2016
4013943
test: fixing linter errors
Dec 1, 2016
e9ea3b2
Merge branch 'testConsoleFixAssertEquals' of github.com:mcrummey/node…
Dec 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing linter errors
  • Loading branch information
Matt Crummey committed Dec 1, 2016
commit 7dc4f586b3433164f8d32779c36181e44d9c90aa
24 changes: 13 additions & 11 deletions test/parallel/test-console.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,28 +35,28 @@ global.process.stderr.write = function(string) {
errStrings.push(string);
};

// test console.log()
// test console.log() goes to stdout
console.log('foo');
console.log('foo', 'bar');
console.log('%s %s', 'foo', 'bar', 'hop');
console.log({slashes: '\\\\'});
console.log(custom_inspect);

// test console.info()
// test console.info() goes to stdout
console.info('foo');
console.info('foo', 'bar');
console.info('%s %s', 'foo', 'bar', 'hop');
console.info({slashes: '\\\\'});
console.info(custom_inspect);

// test console.error()
// test console.error() goes to stderr
console.error('foo');
console.error('foo', 'bar');
console.error('%s %s', 'foo', 'bar', 'hop');
console.error({slashes: '\\\\'});
console.error(custom_inspect);

// test console.warn()
// test console.warn() goes to stderr
console.warn('foo');
console.warn('foo', 'bar');
console.warn('%s %s', 'foo', 'bar', 'hop');
Expand Down Expand Up @@ -102,17 +102,19 @@ const expectedStrings = [
];

for (const expected of expectedStrings) {
assert.strictEqual(expected + '\n', strings.shift()); // console.log (stdout)
assert.strictEqual(expected + '\n', errStrings.shift()); // console.error (stderr)
assert.strictEqual(expected + '\n', strings.shift());
assert.strictEqual(expected + '\n', errStrings.shift());
}

for (const expected of expectedStrings) {
assert.strictEqual(expected + '\n', strings.shift()); // console.info (stdout)
assert.strictEqual(expected + '\n', errStrings.shift()); // console.warn (stderr)
assert.strictEqual(expected + '\n', strings.shift());
assert.strictEqual(expected + '\n', errStrings.shift());
}

assert.strictEqual("{ foo: 'bar', inspect: [Function: inspect] }\n", strings.shift());
assert.strictEqual("{ foo: 'bar', inspect: [Function: inspect] }\n", strings.shift());
assert.strictEqual("{ foo: 'bar', inspect: [Function: inspect] }\n",
strings.shift());
assert.strictEqual("{ foo: 'bar', inspect: [Function: inspect] }\n",
strings.shift());
assert.notEqual(-1, strings.shift().indexOf('foo: [Object]'));
assert.strictEqual(-1, strings.shift().indexOf('baz'));
assert.ok(/^label: \d+\.\d{3}ms$/.test(strings.shift().trim()));
Expand All @@ -121,7 +123,7 @@ assert.ok(/^constructor: \d+\.\d{3}ms$/.test(strings.shift().trim()));
assert.ok(/^hasOwnProperty: \d+\.\d{3}ms$/.test(strings.shift().trim()));

assert.strictEqual('Trace: This is a {"formatted":"trace"} 10 foo',
errStrings.shift().split('\n').shift());
errStrings.shift().split('\n').shift());

assert.strictEqual(strings.length, 0);
assert.strictEqual(errStrings.length, 0);
Expand Down