remove analytics source#2305
Merged
SEWeiTung merged 1 commit intonodejs:masterfrom Jul 1, 2019
MylesBorins:remove-google-analytics
Merged
remove analytics source#2305SEWeiTung merged 1 commit intonodejs:masterfrom MylesBorins:remove-google-analytics
SEWeiTung merged 1 commit intonodejs:masterfrom
MylesBorins:remove-google-analytics
Conversation
We removed GA in 2018 but it seems like we missed removing it from the partials and it is still being loaded. Refs: nodejs/node#23083 Refs: #2302
Trott
approved these changes
Jul 1, 2019
pierreneter
approved these changes
Jul 1, 2019
alexandrtovmach
approved these changes
Jul 1, 2019
Trott
pushed a commit
that referenced
this pull request
Jul 1, 2019
It was still present in one file, previous commit just removed the prefetch. Also remove dnt_helper, it was used only by analytics. Refs: #2305 Refs: nodejs/node#23083 Refs: nodejs/node#22652 Refs: #2302
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We removed GA in 2018 but it seems like we missed removing
it from the partials and it is still being loaded.
Refs: nodejs/node#23083
Refs: #2302