Skip to content

fix some typos and enhance 'advanced' knowledge files#2909

Merged
SEWeiTung merged 11 commits intonodejs:masterfrom
SEWeiTung:FixTypos
Jan 29, 2020
Merged

fix some typos and enhance 'advanced' knowledge files#2909
SEWeiTung merged 11 commits intonodejs:masterfrom
SEWeiTung:FixTypos

Conversation

@SEWeiTung
Copy link
Contributor

@SEWeiTung SEWeiTung commented Jan 24, 2020 •
edited
Loading

  1. Fixtures for some typos.
  2. Add 'console' for some console codes to enhance the formation.
  3. Add some backquotes onto some methods.

fixtures some typos and enhance the knowledge files
a05ebf9 
1. Fixtures for some typos.
2. Add 'bash' for some console codes to enhance the formation.
3. Add some backquotes onto some methods.
4. For Buffer, we have a outdated (obsolated) method before v8.0.0, we
refer it for historical reason with some warning messages.
@SEWeiTung SEWeiTung requested a review from XhmikosR January 24, 2020 07:53
@SEWeiTung
add more comments
fa9bbc2 
Add missing comments
@SEWeiTung SEWeiTung changed the title fixtures some typos and enhance the knowledge files fixtures some typos and enhance 'advanced' knowledge files Jan 24, 2020
@SEWeiTung SEWeiTung requested a review from a team January 24, 2020 08:35
@XhmikosR XhmikosR changed the title fixtures some typos and enhance 'advanced' knowledge files fix some typos and enhance 'advanced' knowledge files Jan 24, 2020
XhmikosR
XhmikosR reviewed Jan 24, 2020
View reviewed changes
Trott
Trott reviewed Jan 24, 2020
View reviewed changes
Trott
Trott reviewed Jan 24, 2020
View reviewed changes
Trott
Trott reviewed Jan 24, 2020
View reviewed changes
Trott
Trott reviewed Jan 24, 2020
View reviewed changes
nschonni
nschonni reviewed Jan 24, 2020
View reviewed changes
Trott
Trott reviewed Jan 26, 2020
View reviewed changes
@Trott
Copy link
Member

Trott commented Jan 26, 2020

If this PR stalls at some point, it would be good to get a PR that just gets rid of the new Buffer() examples. That would likely be approved and merged very quickly.

@SEWeiTung
Copy link
Contributor Author

SEWeiTung commented Jan 26, 2020

If this PR stalls at some point, it would be good to get a PR that just gets rid of the new Buffer() examples. That would likely be approved and merged very quickly.

Agreed, so my change updated 'new Buffer' to 'Buffer.alloc'.

nschonni
nschonni approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to squash and fix the commit message when landing

@SEWeiTung SEWeiTung merged commit 6407120 into nodejs:master Jan 29, 2020
@SEWeiTung SEWeiTung deleted the FixTypos branch January 29, 2020 03:29
@XhmikosR
Copy link
Contributor

XhmikosR commented Jan 30, 2020

This shouldn't have landed with console as a syntax highlighting language. It's unknown to prism.js thus it leads to wrong highlighting.

I'll make a PR to remove it.

@XhmikosR
Copy link
Contributor

XhmikosR commented Jan 30, 2020

We really need PR previews. Also this was sort of showing in the CI build, but it didn't mark it as failed: https://github.com/nodejs/nodejs.org/runs/414306542#step:8:31

We might need to fork metalsmith-prism since the package is archived.

@XhmikosR XhmikosR mentioned this pull request Jan 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XhmikosR XhmikosR Awaiting requested review from XhmikosR

@Trott Trott Awaiting requested review from Trott

1 more reviewer

@nschonni nschonni nschonni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SEWeiTung @Trott @XhmikosR @nschonni