chore: remove unmaintained metalsmith plugins#4551
Merged
Conversation
Replace with inline equivalents. This addresses some security warnings in the GitHub interface and in `npm audit`. (The warnings are relevant to our build tooling, not to the site.)
Member
|
Note sure if the windows failure is related to glob v8 vs. v7. Saw some other Windows failures on other repos that tried bumping glob to v8 |
Member
Author
|
Anyone on a Windows machine want to take a look and see what I'm doing wrong for that platform? @nodejs/platform-windows @nodejs/website |
Member
Author
Downgraded to glob@7 to see if it fixes anything.... |
Member
Author
That seems to have fixed it. Thanks, @nschonni! |
nschonni
approved these changes
Apr 18, 2022
WaleedAshraf
approved these changes
Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace with inline equivalents. This addresses some security warnings
in the GitHub interface and in
npm audit. (The warnings are relevantto our build tooling, not to the site.)