fix: meriyah export map Nitro/Rollup issue#100
Open
timfish wants to merge 1 commit into
Open
Conversation
Member
|
I would be fine with dropping Node 18, but it did only EOL last year so the extended compat window is nice. |
7 tasks
meriyah export map Rollup issuemeriyah export map Nitro/Rollup issue
jsumners-nr
reviewed
Jul 23, 2026
jsumners-nr
left a comment
Contributor
There was a problem hiding this comment.
Dropping v18 is fine by me.
| "astring": "^1.9.0", | ||
| "esquery": "^1.7.0", | ||
| "meriyah": "^6.1.4", | ||
| "meriyah": "^6.0.0", |
Contributor
There was a problem hiding this comment.
I don't understand how this will solve the described issue. I would expect 6.0.0 or >=6.0.0 <6.1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meriyahchanged its export map for 6.1.0 and removed theimportcondition:This causes issues with Nitro and/or the Rollup CommonJs plugin which fails to resolve the required files. The module then can't be found at runtime.
I opened a PR to add this back in meriyah:
importremoved from export map meriyah/meriyah#585However, they are a major ahead of us. Even if this gets merged we can't use it without dropping Node v18 support. @nodejs/orchestrion-js-maintainers does anyone else still need to support Node v18?
I also opened an issue for Nitro:
importcondition nitrojs/nitro#4456This PR downgrades to a
meriyahversion which doesn't cause the issue. Hopefully we can revert this at some point or upgrade to v7?