chore: setup 5.x auto release#3111
Closed
mweberxyz wants to merge 1 commit into
Closed
Conversation
Member
|
Closing this PR since 5.x has been end-of-life since 2024-04-30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3110 for details. Both should merge at the same time.
This relates to...
#3103
Rationale
Add 5.x specific deployment logic to v5.x branch
Changes
Backport
releaseworkflow and release script from main, ensure change logs are generated against previous 5.x release, ensure tag on npm publish isfive, and removepublish-undici-typesworkflow (now taken care of duringreleaseworkflow)Notes
Assuming the
releaseenvironment is set to Protected branches only, branch protection rules must be added forv5.xbranch, as this change will enable automated release on push.Alternatively (for added security) -- the release environment should be limited to exactly the
mainorv5.xbranch, in addition to adding branch protection rules tov5.x.If the following protections are added:
Then this is what a malicious branch and workflow run would look like, with the release blocked:
https://github.com/mweberxyz/nodejs-undici/commits/malicious/
https://github.com/mweberxyz/nodejs-undici/actions/runs/8674454300
Status