Skip to content

test: add headerslist copy check#3156

Merged
mcollina merged 4 commits into
nodejs:mainfrom
tsctx:headers-list-copy-check
Apr 24, 2024
Merged

test: add headerslist copy check#3156
mcollina merged 4 commits into
nodejs:mainfrom
tsctx:headers-list-copy-check

Conversation

@tsctx

@tsctx tsctx commented Apr 23, 2024

Copy link
Copy Markdown
Member

Comment thread test/fetch/request.js Outdated
Comment thread test/fetch/request.js Outdated
@codecov-commenter

codecov-commenter commented Apr 23, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.17%. Comparing base (961b76a) to head (a7c021f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3156   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files          90       90           
  Lines       24302    24302           
=======================================
  Hits        22886    22886           
  Misses       1416     1416           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KhafraDev

Copy link
Copy Markdown
Member

Can you also add a test that for when headers is passed as an option to RequestInit?

Comment thread test/fetch/request.js Outdated
@tsctx

tsctx commented Apr 24, 2024

Copy link
Copy Markdown
Member Author

Added

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants