Skip to content

fix: EnvHttpProxyAgent.Options should accept ProxyAgent.Options #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 1 commit into from
Jun 26, 2025
Merged

fix: EnvHttpProxyAgent.Options should accept ProxyAgent.Options #4243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion types/env-http-proxy-agent.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Agent from './agent'
import ProxyAgent from './proxy-agent'
import Dispatcher from './dispatcher'

export default EnvHttpProxyAgent
Expand All @@ -10,7 +11,7 @@ declare class EnvHttpProxyAgent extends Dispatcher {
}

declare namespace EnvHttpProxyAgent {
export interface Options extends Agent.Options {
export interface Options extends Omit<ProxyAgent.Options, 'uri'> {
/** Overrides the value of the HTTP_PROXY environment variable */
httpProxy?: string;
/** Overrides the value of the HTTPS_PROXY environment variable */
Expand Down
Loading