Skip to content

refactor: snapshot-recorder#4413

Merged
Uzlopak merged 12 commits into
mainfrom
refactor-snapshots
Aug 17, 2025
Merged

refactor: snapshot-recorder#4413
Uzlopak merged 12 commits into
mainfrom
refactor-snapshots

Conversation

@Uzlopak

@Uzlopak Uzlopak commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

I used jsdoc to make a static code analysis. I found some redundant calculations etc.. "Simplified" it.

@mcollina

@Uzlopak Uzlopak marked this pull request as ready for review August 15, 2025 12:20
@Uzlopak

Uzlopak commented Aug 17, 2025

Copy link
Copy Markdown
Contributor Author

I think I maybe fixed that flaky test regarding auto flush.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 5453139 into main Aug 17, 2025
32 of 33 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 17, 2025
@Uzlopak Uzlopak deleted the refactor-snapshots branch August 21, 2025 11:31
slagiewka pushed a commit to slagiewka/undici that referenced this pull request Feb 14, 2026
* refactor: snapshot-recorder

* improve further

* simplify matchHeaders

* remove unnecessary case

* simplify

* improve

* reuse sets

* simplify

* improve

* more jsdoc

* fix potential race condition

* one last flush
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants