fix: backport 401 stream-backed body fix to v7.x#5006
Merged
Conversation
* fix: avoid 401 failures for stream-backed request bodies - Properly implement isTraversableNavigable() to return false in Node.js - Return 401 response directly for stream-backed bodies instead of throwing network error - Aligns with Fetch spec discussion in whatwg/fetch#1132 - Add regression tests for PUT with ReadableStream and POST with JSON body * fix: preserve 401 auth retries for URL credentials (cherry picked from commit 4f4bf4f) Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v7.x #5006 +/- ##
==========================================
- Coverage 92.92% 92.85% -0.08%
==========================================
Files 112 112
Lines 35725 35740 +15
==========================================
- Hits 33199 33185 -14
- Misses 2526 2555 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport #4941 to
v7.x.This fixes the 401/auth retry regression for stream-backed request bodies introduced by #4747 in
v7.19.0.Changes
isTraversableNavigable()return false in Node.js contextsexpected non-null body sourcefor stream-backed request bodies when no auth retry will occurValidation
./node_modules/.bin/borp -p "test/fetch/401-statuscode-no-infinite-loop.js"Fixes #5004