fix(http2): avoid double-decrementing open streams on timeout#5074
Closed
trivikr wants to merge 1 commit into
Closed
fix(http2): avoid double-decrementing open streams on timeout#5074trivikr wants to merge 1 commit into
trivikr wants to merge 1 commit into
Conversation
Assisted-by: openai:gpt-5.4 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5074 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 110 110
Lines 35799 35793 -6
=======================================
- Hits 33329 33325 -4
+ Misses 2470 2468 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Merged in #5076 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes: #5073
Rationale
client-h2.jswas decrementingsession[kOpenStreams]in both thetimeouthandler and the streamclosehandler.Since the timeout path aborts and closes the stream, a single timed-out request could underflow the counter and skew H2 session ref/unref bookkeeping.
Changes
session[kOpenStreams]decrement from the HTTP/2 stream timeout handler.closehandler.Features
N/A
Bug Fixes
Prevent
kOpenStreamsfrom being decremented twice for a single timed-out HTTP/2 request.Breaking Changes and Deprecations
N/A
Status