test(wpt): increase server readiness timeout on Windows to 60s#5214
Closed
trivikr wants to merge 1 commit into
Closed
test(wpt): increase server readiness timeout on Windows to 60s#5214trivikr wants to merge 1 commit into
trivikr wants to merge 1 commit into
Conversation
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5214 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 110 110
Lines 36353 36353
=======================================
Hits 33906 33906
Misses 2447 2447 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Converted to draft as increasing timeout might not help. The WSS server doesn't emit "Listen on:" in the logs [2026-04-17 15:09:21,404 http-public on port 52583] INFO - Starting http server on http://web-platform.test:52583/
[2026-04-17 15:09:22,589 http-local on port 52582] INFO - Starting http server on http://web-platform.test:52582/
[2026-04-17 15:09:22,591 http on port 52581] INFO - Starting http server on http://web-platform.test:52581/
[2026-04-17 15:09:22,591 http on port 8000] INFO - Starting http server on http://web-platform.test:8000/
[2026-04-17 15:09:34,414 wss on port 52587] INFO - Create socket on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 52587))
[2026-04-17 15:09:34,418 ws on port 52586] INFO - Create socket on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 52586))
[2026-04-17 15:09:34,418 ws on port 52586] INFO - Bind on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 52586))
[2026-04-17 15:09:34,418 ws on port 52586] INFO - Listen on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 52586))
file:///D:/a/undici/undici/test/web-platform-tests/wpt-runner.mjs:180
rejectReady(new Error(`Timed out waiting for WPT server readiness. Missing: ${missing}`))
^
Error: Timed out waiting for WPT server readiness. Missing: https-8443, https-8444, https-local, https-public, wss, h2
at Timeout.<anonymous> (file:///D:/a/undici/undici/test/web-platform-tests/wpt-runner.mjs:180:19)
at listOnTimeout (node:internal/timers:605:17)
at process.processTimers (node:internal/timers:541:7)Logs: https://github.com/nodejs/undici/actions/runs/24571862888/job/71846864775 This points more toward an intermittent SSL/TLS initialization failure on Windows rather than pure slowness. Since https-8443, https-8444 and other servers don't appear in logs, the WPT server might be failing to launch those listeners, not that they're slow. |
Member
Author
|
Instead of increasing timeout, attempting retry in #5215 is a better solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Refs: #5184
Rationale
The WPT runner waits for all sub-servers (HTTP, HTTPS, WSS, H2) to report readiness before running tests. On Windows CI runners, the TLS-dependent servers (https-8443, https-8444, https-local, https-public, wss, h2) occasionally take longer than 30 seconds to initialize due to resource pressure, causing a timeout and failing the entire test run.
Changes
Increase the server readiness timeout from 30s to 60s on Windows. Other platforms keep the 30s timeout.
Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status