Skip to content

http2: remove redundant request stream binding#5302

Merged
metcoder95 merged 1 commit into
nodejs:mainfrom
trivikr:h2-redundant-request-stream-binding
May 18, 2026
Merged

http2: remove redundant request stream binding#5302
metcoder95 merged 1 commit into
nodejs:mainfrom
trivikr:h2-redundant-request-stream-binding

Conversation

@trivikr

@trivikr trivikr commented May 13, 2026

Copy link
Copy Markdown
Member

This relates to...

Redundant HTTP/2 request-stream binding in client-h2.js.

Rationale

The normal HTTP/2 request path was calling bindRequestToStream() twice for the same stream. The first call used null cleanup and was immediately replaced by the second binding with releaseRequestStream, so it was redundant.

Changes

  • Remove the redundant initial bindRequestToStream(request, stream, null) call from the HTTP/2 request path.
  • Add regression coverage for abort-before-response handling after an HTTP/2 stream has been assigned, ensuring request stream references are cleared.

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

Assisted-by: openai:gpt-5.5

Assisted-by: openai:gpt-5.5
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.23%. Comparing base (314ba6a) to head (6e568f7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5302   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files         110      110           
  Lines       36575    36574    -1     
=======================================
+ Hits        34099    34101    +2     
+ Misses       2476     2473    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metcoder95 metcoder95 merged commit 81fdf87 into nodejs:main May 18, 2026
38 checks passed
@github-actions github-actions Bot mentioned this pull request Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants