Skip to content

fix: keep idle validation on global timers#5409

Merged
mcollina merged 1 commit into
nodejs:v7.xfrom
mcollina:fix/idle-validation-test-timers-v7
Jun 10, 2026
Merged

fix: keep idle validation on global timers#5409
mcollina merged 1 commit into
nodejs:v7.xfrom
mcollina:fix/idle-validation-test-timers-v7

Conversation

@mcollina

Copy link
Copy Markdown
Member

Summary

  • backport fix: keep idle validation on global timers #5407 to v7.x
  • restore idle socket validation to use the normal global timer APIs instead of bypassing fake timers through node:timers
  • update cache interceptor tests to fake only Date, which is the only clock behavior they need to control

Tests

  • node --test test/interceptors/cache.js
  • node --test test/response-queue-poisoning.js test/issue-810.js
  • npm run lint -- --quiet

Signed-off-by: Matteo Collina <hello@matteocollina.com>
(cherry picked from commit 9290322)
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.88%. Comparing base (8e4046e) to head (1bd3bf9).

Additional details and impacted files
@@            Coverage Diff             @@
##             v7.x    #5409      +/-   ##
==========================================
- Coverage   92.88%   92.88%   -0.01%     
==========================================
  Files         112      112              
  Lines       35912    35911       -1     
==========================================
- Hits        33357    33356       -1     
  Misses       2555     2555              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina merged commit 0fa8086 into nodejs:v7.x Jun 10, 2026
67 of 70 checks passed
@github-actions github-actions Bot mentioned this pull request Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants