fix(fetch): convert null init in Response.json#5540
Merged
Conversation
Signed-off-by: Ram-blip <ramcruze2000@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5540 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 110 110
Lines 37376 37374 -2
=======================================
- Hits 34928 34927 -1
+ Misses 2448 2447 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tsctx
approved these changes
Jul 10, 2026
KhafraDev
approved these changes
Jul 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes
Response.json(data, null)sonullis handled throughResponseInitconversion instead of being passed directly to response initialization.Rationale
Response.json()takes an optionalResponseInitdictionary. Web IDL dictionary conversion allowsnull, treating dictionary members as absent so defaults apply.Response.json()was skippingResponseInitconversion wheninitwasnull, which caused rawnullto reachinitializeResponse()and throw when readinginit.status.This change routes
nullthrough the existingResponseInitconverter, matching the behavior already used by theResponseconstructor.Changes
initwithwebidl.converters.ResponseInit()inResponse.json().Response.json(data, null)in the existingINIT_TESTStable.Features
N/A
Bug Fixes
Fixes
Response.json(data, null)throwingTypeError.Breaking Changes and Deprecations
N/A
Status