test(h2): isolate connection churn seeds - #5643
Open
mcollina wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5643 +/- ##
==========================================
+ Coverage 93.40% 93.42% +0.01%
==========================================
Files 110 110
Lines 38695 38695
==========================================
+ Hits 36144 36150 +6
+ Misses 2551 2545 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
It’s worse than that, there is a bug in Node 24 that’s causing a sigsev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope the HTTP/2 churn test cleanup to each seed so its TLS server, sessions, agent, and keepalive timer are released before the next seed starts.
Native Linux x64 investigation showed that the remaining Node.js 24 failures are process-level memory-corruption crashes, not assertions from this test. Although the cores usually fail later in V8's concurrent Maglev compiler, the source is Node's HTTP/2 binding calling nghttp2 send/close paths reentrantly while
nghttp2_session_mem_recv()is active. The related Node fix is nodejs/node#64166.The Node.js 24 backport needed additional lifecycle adaptations. The existing REFUSED_STREAM deferral alone still crashed in 2/256 concurrent runs, while the adapted full fix completed 256/256 concurrent runs, all 277 Node HTTP/2 tests, and all 116 Undici HTTP/2 tests.
Until a fixed Node.js 24 release is available, run its CI jobs through a wrapper that passes
--no-maglev. This suppresses the observed crash but is only a temporary mitigation for the corrupted state reaching Maglev, not the root fix. A wrapper is required because V8 flags are not accepted throughNODE_OPTIONS. Other Node.js versions continue to run with their default V8 configuration.