Add Pytest and tests for dsu (#5)#8
Merged
Conversation
not522
reviewed
Sep 12, 2020
not522
left a comment
Owner
There was a problem hiding this comment.
テストは全体的にこのくらいの量でいいと思いますが、以下のテストを追加してください。
- 何も
mergeしていない時点での挙動 - 既に同じグループになっている要素を
mergeした時の挙動 - 範囲外のindexを指定した時にassertに引っかかること
Owner
|
|
Contributor
Author
|
ご丁寧なレビューをありがとうございます。
修正いたします。 |
Contributor
Author
WHAT
該当メソッド:
該当メソッド:
該当メソッド:
Questions
|
Contributor
Author
WHAT
|
not522
reviewed
Sep 13, 2020
Owner
|
ありがとうございます。マージします! |
Contributor
Author
|
ありがとうございます。 ご丁寧にレビューしていただき、とても感謝しております。 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Questions