Skip to content

bump: update oras-go to v2.3.0#347

Merged
JeyJeyGao merged 5 commits into
notaryproject:mainfrom
JeyJeyGao:feat/update_oras_go_2.3.0
Sep 15, 2023
Merged

bump: update oras-go to v2.3.0#347
JeyJeyGao merged 5 commits into
notaryproject:mainfrom
JeyJeyGao:feat/update_oras_go_2.3.0

Conversation

@JeyJeyGao
Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao commented Aug 31, 2023

  • Update oras-go to v2.3.0.
  • Replace oras.Pack() with oras.PackManifest() as it is deprecated in v2.3.0.
  • Generate an empty config blob manually, as oras.PackManifest() does not generate the config blob with the notation artifact type as the media type.

Resolves #346
Signed-off-by: Junjie Gao junjiegao@microsoft.com

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 31, 2023

Codecov Report

❌ Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.68%. Comparing base (c6bc5e0) to head (01623ad).
⚠️ Report is 125 commits behind head on main.

Files with missing lines Patch % Lines
registry/repository.go 59.09% 6 Missing and 3 partials ⚠️

❌ Your project status has failed because the head coverage (74.68%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   74.88%   74.68%   -0.21%     
==========================================
  Files          23       23              
  Lines        2210     2228      +18     
==========================================
+ Hits         1655     1664       +9     
- Misses        437      443       +6     
- Partials      118      121       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
ghost
ghost previously approved these changes Aug 31, 2023
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread registry/repository.go Outdated
@shizhMSFT shizhMSFT changed the title fix: update oras-go v2.3.0 bump: update oras-go to v2.3.0 Aug 31, 2023
shizhMSFT
shizhMSFT previously approved these changes Aug 31, 2023
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread registry/repository.go Outdated
Comment thread registry/repository.go Outdated
Comment thread registry/repository.go Outdated
Comment thread registry/repository.go Outdated
Comment thread registry/repository.go Outdated
@JeyJeyGao JeyJeyGao dismissed stale reviews from shizhMSFT and ghost via 9dfdb3b September 1, 2023 02:09
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao force-pushed the feat/update_oras_go_2.3.0 branch from 9dfdb3b to 7e008e6 Compare September 1, 2023 02:26
shizhMSFT
shizhMSFT previously approved these changes Sep 1, 2023
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread registry/repository.go
Copy link
Copy Markdown
Contributor

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link
Copy Markdown
Contributor

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 60d9cdc into notaryproject:main Sep 15, 2023
@shizhMSFT shizhMSFT mentioned this pull request Oct 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oras-go updated v2.3.0

6 participants