feat(refs): react-portfolio-engineer (Level 2→3)#378
Merged
Conversation
…nces (Level 2→3) Add two reference files covering gaps identified by audit: - testing.md: RNTL 12+ patterns, jest-expo config, native module mocking, async assertion patterns, anti-patterns (testID queries, snapshots, per-file navigation mocks), error-fix mappings with detection commands - error-handling.md: ErrorBoundary setup, Sentry init sequence, unhandled promise rejection capture, typed fetch error handling, anti-patterns (empty catch, console.error-only, missing boundaries), detection commands Update agent loading table and error handling section to route to new files. Detection commands in both files push aggregate level from 2 to 3.
…d Core Web Vitals (Level 2→3) Adds two reference files to lift react-portfolio-engineer from Level 2 to Level 3: - nextjs-app-router.md: App Router Server vs Client component split, generateStaticParams, generateMetadata per artwork, URL search params for category filtering, anti-patterns for 'use client' on full pages and legacy getServerSideProps in app/ directory - performance.md: Core Web Vitals targets (LCP/CLS/INP), priority loading for hero images, explicit width/height to prevent CLS, responsive sizes prop, dynamic imports for lightbox, anti-patterns for multiple priority props, missing sizes, unsync filter without useMemo, barrel icon library imports Both files include detection commands (grep/rg) and error-fix mappings. Loading table in agent body updated to map task signals to reference files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-portfolio-engineerfrom Level 2 to Level 3 (verified by audit script)Targets Processed
New Reference Files
references/nextjs-app-router.md(295 lines, concrete=72, cmds=Y)'use client'generateStaticParamsandgenerateMetadataper artwork for SSG and OG imagesuseState)'use client',getServerSidePropsin app/ directory, missing Suspense arounduseSearchParamsreferences/performance.md(312 lines, concrete=77, cmds=Y)priorityprop for hero LCP image; explicitwidth/heightto prevent CLSsizesprop to cut mobile image payload 50-70%priorityprops, missingsizes, unsync filter withoutuseMemo, barrel icon imports, plain<img>tagsValidation Gate
python3 scripts/validate-references.py --agent react-portfolio-engineer: 5/5 references present, 0 issues