Open
Conversation
Author
|
@samhed, please check this PR |
samhed
requested changes
Mar 24, 2026
Member
samhed
left a comment
samhed
left a comment
There was a problem hiding this comment.
Thanks for your contribution. I didn't test it yet, but a few comments from briefly checking the code.
app/ui.js
Outdated
| if ((Date.now() - UI.firstReconnectTime) >= maxTime) { | ||
| // hiding the previous status message | ||
| UI.hideStatus(); | ||
| UI.showStatus(_("Maximum reconnect attempts reached. Failed to connect to the server."), 'error', 1000*60*240); // Show for 4 hours |
Member
There was a problem hiding this comment.
Why would this be limited in how long it is shown?
Author
There was a problem hiding this comment.
I have changed it to a long time.
Member
There was a problem hiding this comment.
Did you test that code? Such a timeout executes instantly for me. See https://developer.mozilla.org/en-US/docs/Web/API/Window/setTimeout#maximum_delay_value
I'd suggest modifying showStatus to do what you want instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update introduces a maximum reconnect timeout for the VNC client. Currently, when the VNC client attempts to reconnect, it may continue retrying indefinitely if the connection keeps failing, which is not ideal.
With this change, we add a new configuration key, reconnect_max_time, in default.json. This setting allows us to define a maximum duration for reconnection attempts. Once the specified time limit is reached, the client will stop trying to reconnect, preventing unnecessary retries and improving overall stability.