Enable attaching the control bar to top and bottom#2043
Enable attaching the control bar to top and bottom#2043tobfah wants to merge 8 commits intonovnc:masterfrom
Conversation
In preparation for top and bottom modes
Facilitates a horizontal control bar
Facilitates a horizontal control bar
Simplifies alignment for vertical and horizontal control bar modes
tobfah
force-pushed
the
enable-horizontal-control-bar
branch
from
edbef63 to
3b0ba39
Compare
|
Tested the implementation on Epiphany v40.2 and Chromium v144 on Fedora 43 and found no issues. Regarding the decision to not use a relative offset for the |
samhed
left a comment
samhed
left a comment
There was a problem hiding this comment.
Funkar bra, har testat på Chrome (Linux) och Firefox (Android), mycket trevlig funktion!
Ifall slutresultatet är tänkt att ha uppdelade commits bör du nog nämna i alla commits vilken relation de har till huvudproblemet.
app/ui.js
Outdated
|
|
||
| const anchor = document.getElementById('noVNC_control_bar_anchor'); | ||
| if (anchor.classList.contains("noVNC_right")) { | ||
| const anchorAndDescendants = [anchor, ...anchor.querySelectorAll('*')]; |
There was a problem hiding this comment.
Varför behöver vi jobba med descendants här? Borde inte css-selectors lösa det?
There was a problem hiding this comment.
Nämn gärna att denna commit är förberedande för att tillåta att flytta control bar
There's only one button in the group, and the wrapping div messed with the flex box layout
tobfah
force-pushed
the
enable-horizontal-control-bar
branch
from
3b0ba39 to
cea37c8
Compare
3 participants
This PR enables attaching the control bar to the top and bottom positions, in addition to the traditional left and right positions.
Tested on