Sync EF Core to 7.0.0-preview.5.22260.3#2369
Merged
roji merged 2 commits intonpgsql:mainfrom May 23, 2022
Merged
Conversation
roji
commented
May 16, 2022
|
|
||
| namespace Npgsql.EntityFrameworkCore.PostgreSQL.Query.Internal; | ||
|
|
||
| public class NpgsqlSetOperationTypeResolutionCompensatingExpressionVisitor : ExpressionVisitor |
Member
Author
There was a problem hiding this comment.
@smitpatel this is the visitor which fixes the PG set operation thing (#2366). As it's a bit tricky it would be great if you could take a look (but only if you have time).
roji
commented
May 16, 2022
| } | ||
| } | ||
|
|
||
| #pragma warning disable EF1001 |
Member
Author
There was a problem hiding this comment.
@smitpatel as discussed offline, am merging with this temporary hack which accesses TpcTablesExpression - will clean this up later based on what you decide.
Member
Author
|
@smitpatel FYI merging this for now with the code accessing the internal TpcTablesExpression - we can clean this up later whenever you have time to look at it from the EF side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And fix nested set operations with leftmost nulls
Fixes #2366